How do you deal with code review feedback being mostly ignored?

Hi all,

This is something that has been bothering me a bit recently.

On my relatively small ish team, I feel as if my confidence has actually taken a hit because of our recent code reviews. It seems like on the vast majority of comments I leave, my feedback is either ignored or I have to really push for something to actually get implemented.

When I say ignored, I don’t mean ignored completely, but more so that I will (for example) comment “can we do X for readability?” Or something of the like. And the response will be “actually, I think we usually do this instead” and the task will be checked off.

Everyone on the team except for our tech lead is the same title, for context. I am on the higher end experience wise, though.

I am wondering if I can be more assertive without coming across as difficult, and if anyone else has dealt with this before. We’ve had some (in my opinion) pretty tough-to-maintain code go out recently that we’ve already had to refactor in further tickets, and I think a big part of it is code reviews being a large back and forth.

Posted Oct 1, 2024, 11:59 AM UTC

41113
Loading comments…