Should I be done

Hi guys.. please don’t judge me on this I have been with my boyfriend for almost 2 and a half years. We had an amazing relationship at the start but idk after a while it started to plummet. We don’t go on dates, we fight and bicker about tiny things, but it only got worse around earlier this year when we were on vacation for my birthday and I received nothing from him. I understand the vacation was very expensive but I didn’t even receive a card from my own boyfriend, I don’t even want a present honestly just more of a gesture. Then I made a joke about it in front of our friends (I shouldn’t have) and he completely snapped at me and said things like “next time you fuck up im going to embarrass you in front of everybody” this was the first of Many times he has snapped at me in that way. This really hurt me and affected me because I’ve never done that. And when we got home he spent over $1k on performance pipes for his car, then bought me a necklace after showing I was upset. The pipes really pissed me off and was also the first of many stupid shit he bought for his car when he doesn’t have money like that ( he had to afterpay this stuff) We used to be such a good team, when he didn’t have a car I helped drive him to work on my off days and picked him up, he’s helped me when I was unemployed but I just feel like some of the efforts aren’t there anymore:( we have had numerous talks about how we will fix it and two days later it goes back to normal. Fast forward things were not working, he stopped complimenting me (I got really bad at this as well) he didn’t want to do anything with me anymore, he complained Everytime we shopped and made it seem like a big deal, rush me and make me feel bad for there (I don’t have much money so it was either window shopping or getting birthday stuff for friends) I also felt like video games were being chosen over me and it really hurt. I’ve talked to him about this so many times but it always comes back the same way it was. He has a really bad attitude with me I’ve noticed, a short temper and the way he talks is really mean even if he says he doesn’t mean it. About two months ago we broke up and have recently gotten back together to work it out. During the break up we were still in contact and she showed me so much love and did so many things for me, planned a date and it was really sweet. But just as I worried things went back to the way we were after we got back together. ( I’m so sorry this is scrambled im thinking as I type) he has a very hard and sad home life at the moment and I do believe that’s a factor to a bunch of things but not entirely an excuse. I miss my boyfriend I’m trying to be a good girlfriend I’m trying to be better I compliment him, give him company, hug him kiss him try to be obsessed with him but I don’t receive it back. He has posted his car more than me, I know that shouldn’t depict my relationship but it’s nice once in a while you know? I also have to throw this out he does show me love but not very much physically, his actions are very loving he buys me things I want, he drives me most of the time which I do very much appreciate and I tell him that. But I also feel that when I bring it up it gets brushed off because he’s already doing that why should he do the other if that makes sense. I get no physical love I feel like, I wanna be kissed and hugged when I’m sad like I do for him but it’s never there. It never has been there, I have to ask for everything and it’s so hurtful. I know there’s so many things I can be doing as well and I’m really trying but I don’t know if I should keep doing this. I had a dream last night about a boy I’ve never even met or seen before give me love and compliment me, his face lit up when he saw me and was excited to hangout. I don’t know if that means anything but the timing was just weird and kinda made me come to realization that I need to figure out what I want. Please don’t judge me on this I just genuinely want to know what you guys thing I want feedback and insight not hate please I apologize if it makes no sense