Broke up (21F) with boyfriend (21M) over religion

Basically title, I am christian and he is atheist. We have been dating for almost two years. He had said he wanted to try things out and went to church a few times but ultimately decided he would not convert (which I am of course okay with, I saw this coming) but also he would not want his kids going to church, which was a dealbreaker for me. Originally we’d thought if we made it and had kids they could go but make their own decision about their beliefs, so to hear he made up his mind so strongly in that way hurt.

Other than that, our relationship was perfect. He is so kind, so gentle and so good at communicating (ie him being honest with me about this once he realized). I am worried we are making the wrong decision and I am letting go of my person.

Advice?