How to play damage?

Asking this here cause I mostly play dive (even while tanking) . I play mostly elsa and bit of mk when dive aint working and somehow I still don't have enough damage . It's bout 20 k while playing elsa which feels low to me and I tend to often die as well, what are some things I should and shouldn't be doing while damage than dive