Can anybody make Code review for Java code written in FP?
Hello everyone, I'm a newbie here
I know it's Scala community, but I want in near future become scala programmer.
I received these assignments in high school, and they said that I should do them with OOP and Java, however, I did them with FP (: .
So, can anybody review this code? Because nobody in high school can't read it
git repo: https://github.com/egoarka/itmo-oop
1 lab - skip this
2 lab - skip this
3 lab - may be reviewed (it's ini parser)
4 lab - may be reviewed (it's big assignment (in short: it's shop), should consist of dao layers and service layers)
daos interfaces:
whole business layer is written with fp (so i think it's easier to read and support in future)
5 lab - may be reviewed (it's XML serializer from POJO to XML)
In addition
- How would you rate mine code?
- I made for all these labs unit tests, what do you think about them too?
thank you in advance
Posted Dec 16, 2018, 11:16 PM UTC · edited