Tribute Page Feedback
Hello,
I just finished up the tribute page project. Any and all feedback would be appreciated.
Here's the link to the codepen.
Thank you in advance!
Posted Dec 9, 2019, 12:40 PM UTC
74
Looks great to me (I’m on my phone too). Good job.
2
Looks good! Great job. Only thing I notice(and note I’m on my phone.) is that the margins around the image are uneven. https://i.imgur.com/r9ORuC1.jpg
I’d suggest looking into the
box-sizingCSS property, particularly theborder-boxvalue to possibly fix this.Nice catch! I didn’t see that on desktop. I’ll take a look into it. (And start double-checking everything on my phone.)
Thanks for your help!
Of course.
It’s been a while since I’ve been on FCC so not sure if they cover this concept but keep in mind websites are most often viewed on mobile phones these days. So instead of building desktop down, go from mobile up. I think you’ll find it much easier to build your sites that way.
Good luck!