r/neovim•
Whoopska

Crediting original authors on vim/vim patches?

When I look through the neovim history, I see a lot of patches that were yanked from vim, munged, and applied to neovim. The neovim/neovim commit messages look like

vim-patch:8.2.0010: test64 is old style

Problem:    Test64 is old style.
Solution:   Convert to new style test. (Yegappan Lakshmanan, closes vim/vim#5363)
vim/vim@f9cb05c

where the vim/vim commit looks like

patch 8.2.0010: test64 is old style

Problem:    Test64 is old style.
Solution:   Convert to new style test. (Yegappan Lakshmanan, closes #5363)

which Bram patched from a pull request

Convert test64 into a new style test

Should the neovim commit generated (an probably frequently manually edited) by scripts/vim-patch.sh credit the original author in any way or is that asking for problems? One way to do this would be with a line in the commit message like

Co-authored-by: Yegappan Lakshmanan <[email protected]>

which is a githubism and may not be available for patches sent directly to the mailing list but can at least be used when the original commit was on github.

Posted Dec 18, 2019, 3:32 AM UTC

174
jdhao•

The suggestion should go to neovim issues on github.

13
justinmkNeovim contributor•

Should the neovim commit generated (an probably frequently manually edited) by scripts/vim-patch.sh credit the original author in any way

I don't understand your question. The Nvim commit message is almost identical to the Vim commit message. In the examples you gave the author (Yegappan Lakshmanan...) is mentioned.

Co-authored-by: Yegappan Lakshmanan <[email protected]>

That won't work because Bram doesn't include the email of the authors. We would have to track them down manually.

2
WhoopskaOP•

I don't think Bram is crediting the authors well and I think with a little extra manual work or some probably brittle code, neovim could do better.

It's definitely not a suggestion yet, I was hoping to see if people thought it was a good idea, if it would cause more trouble by alerting authors their commits has be reapplied somewhere else possibly with modifications, if it would help grow the neovim community meaningfully by doing it better than Bram, or had other aspects I hadn't thought of.

1
justinmkNeovim contributor•

That's a valid idea, but it's just not going to be a high priority right now. If we had more people helping with Vim patches it might be feasible, but meanwhile we need to aggressively avoid friction where possible.

3