Crediting original authors on vim/vim patches?
When I look through the neovim history, I see a lot of patches that were yanked from vim, munged, and applied to neovim. The neovim/neovim commit messages look like
vim-patch:8.2.0010: test64 is old style
Problem: Test64 is old style.
Solution: Convert to new style test. (Yegappan Lakshmanan, closes vim/vim#5363)
vim/vim@f9cb05c
where the vim/vim commit looks like
patch 8.2.0010: test64 is old style
Problem: Test64 is old style.
Solution: Convert to new style test. (Yegappan Lakshmanan, closes #5363)
which Bram patched from a pull request
Convert test64 into a new style test
Should the neovim commit generated (an probably frequently manually edited) by scripts/vim-patch.sh credit the original author in any way or is that asking for problems? One way to do this would be with a line in the commit message like
Co-authored-by: Yegappan Lakshmanan <[email protected]>
which is a githubism and may not be available for patches sent directly to the mailing list but can at least be used when the original commit was on github.
Posted Dec 18, 2019, 3:32 AM UTC
The suggestion should go to neovim issues on github.