emdaut

u/emdaut


r/reviewmycode•

Hi! I have two different versions of the same function. From a purely organizational perspective which, in your eyes, is better? Why? Please assume any context is supplied (eg: vm, constants, etc) and that both work equally well. Thanks!!

OPTION A:

function loadPlaylistsMatchingFilters() {
    if (vm.langOption === LANGUAGE_OPTIONS.INTERNATIONAL) {
        return crushInterface
            .getSpecificationsByAttributesExcludingRegions(vm.showId, vm.eyeOption.ids, vm.purpose.id, DOMESTIC_REGION_CODE)
            .then(captureActiveRevIds);
    }

    if (vm.langOption === DOMESTIC_REGION_CODE) {
        return crushInterface
            .getSp
12

You've reached the end of this feed.