Source
r/SMAPI•
Coriform

Game hangs when sleeping; appears to be some interaction between MARGO and SDE (some SDE spoilers)

Spoilerdiscussion

This is mostly an FYI if anyone else is seeing their game freeze when going to sleep (but not actual crash or crash log generated). This might happen in other situations, but below I'll describe the specific problem.

With the latest (2.3.0) version of MARGO, and after completing the Aurora Vineyard starfruit bundle, if I visit the Vineyard and have the cutscene with Apples, then go to bed, my game always hangs indefinitely (black screen with loading indicator on mouse, doesn't save). Through some trial and error I learned that if I disable the combat module in MARGO, this issue doesn't happen. (in the end I just ended up reverting to the previous version of MARGO).

Interestingly, the MARGO mod is under moderation review on Nexus atm; I'm unsure if this is related.

A different user posted an Issue on the MARGO gitlab here:
https://gitlab.com/daleao/sdv-mods/-/issues/1

TL;DR: If you use SDE and MARGO and updated MARGO recently, and your game is freezing when going to bed, try disabling the combat module in MARGO.

Posted May 6, 2023, 4:47 PM UTC

613
SnooWords7744•

Margo is just buggy and poorly coded, the combat module is currently preventing many folks from saving. It has numerous bad interactions with other mods but bugs out just fine on its own with all modules installed and being the only mod installed.

3
SakuraKoiMaji•

Margo is just buggy and poorly coded

While I wouldn't argue that, the new features proved that (like some bleed animations persisting until game quit), I must say that I'm otherwise quite happy with (and you could say addicted to) everything else that the mod offers. Except taxes, I only pay my bills.

There are many incompatibilities which one can't easily check currently (without direct links) but most are from redundant or overlapping mods. This 'freeze until the PC dies' (SDE) is the only significant issue I encountered with 603 mods.

It's worth noting that, like described, any other mod that adds or changes monsters will result in a chain of errors. No memory leak but no new day either.

Now, I did try 2.3.1 but either I installed it wrong (likely) or it is still broken, all I can do currently is wait... and play. The combat module I'll just keep off since it doesn't add that great of a change. In terms of quantity, it's just Status Effects, new damage formula and adjustable/random stats and the quality/significance I'd argue to be 'meh'.

0
AutoModeratorMOD•

If you're looking for help with a mod, make sure your post or top-level comment includes:

  • a link to your SMAPI log (see instructions on that page);
  • a description of the issue with as much detail as possible;
  • screenshots/GIFs/videos of the issue if applicable.

See common issues and solutions. If you're having trouble installing SMAPI, see the detailed Getting Started guide.

If you've already done these steps or you're not asking for help with a mod, then please ignore this. Thank you!

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

1
jack-macgrath•

Thats why people use downgraded versions

1
Aletlet•

This is happening to me too, but it is definitely not related to that specific cutscene, it’s just happening any time I want to sleep. I tried loading different save files and starting new games and it happens every. Single. Time. I even tried going to sleep directly after waking up to see if there was any specific action I was taking that was causing a glitch.

I just checked Nexus to see if there was a patch released and it’s under moderation, so I came here to see if anyone knows anything more. Bummer.

1
Effective_Ad_7741•

I think 2.27 is the last stable version. I'd use that one if possible.

1
Preacher_Generic•

I ran into this issue after updating to 2.2.8, reverting to 2.2.7 did resolve it.

1
Effective_Ad_7741•

Hi, I just looked at that post on the gitlab and I am wondering how to view evidence of this memory leak in the posted log ? Just for future reference so I'd know what to look for. All I know about memory leaks is the ultimate OOM exception error that can happen sometimes on older computers or when playing many days in the game without restarting it. (Very much a noob and wanting to learn more about computer stuff)

1
CoriformOP•

I didn't create that issue on gitlab so I'm not sure, but I don't think there's anything specific in the log that shows evidence of a memory leak. I'm honestly not sure if it's a memory leak - that would normally end up in a proper crash.

What's happening - when the app hangs and becomes unresponsive, that's usually due to something like an infinite loop. For example, if the game was waiting on some state to change from false to true and it's not waiting in an asynchronous way (that is, the program is waiting on this before continuing execution) then it will hang or "freeze."

SOMETIMES this can result to an error/exception, esp if you see like the same error repeating over and over again at the end of a log. Tho I didn't see any suspicious errors in my logs or in the log in that posted issue.

I only ended up discovering it was MARGO from trial and error (removing/adding mods from my game, and reproducing the conditions to cause the hang) which was pretty time-consuming, I don't recommend it lol.

1
Effective_Ad_7741•

Thanks for the info, this is helpful!

1
mexcrowbear•

https://imgur.com/a/TYUWZUT I captured this after doing some tests of my own. Can confirm that downgrading MARGO to 2.2.7 fixed the issue. This is a new, fresh build from 2020~ so the PC is as up to date as possible with 32 gigs of ddr4 ram.

1
Effective_Ad_7741•

Oh, I see. You opened the task manager menu to see how much juice it's sucking out. Super tiny ss BTW, almost missed it! XD

1
lemurkat•

SVE itself is fine!

Margo is (hopefully) being repaired.

1