A new year, a new look!
Posted Jan 11, 2012, 1:12 AM UTC · edited
Posted Jan 11, 2012, 1:12 AM UTC · edited
I love the dropdown menu, awesome! Although it gets a bit lost against some backgrounds.
However, the submit button isn't doing it for me. It is very similar in appearance to the searchbox, and is right next to it. So you have two different interface elements sharing a common look. This will be confusing. My personal opinion is that while moving the submit button might be OK, and while changing the look of the submit button might be OK, moving the button AND changing the look AND placing it next to a different interface element with a different function which looks the same is a bad idea.
The submit button also seems to be using absolute positioning, which I personally don't approve of as it breaks my redditbar hider. This was a problem before the new CSS however, although it was only visible on the sticky 'check out our sister reddit, xxx'. (Edit: Not just a problem in the porns, the stickies in r/pics, r/politics, r/help etc also break the hider - haven't tried to fix it yet either, so I don't think it's a big deal, but this said, is absolute positioning really necessary? It's not addon-friendly. Stickies apparently cause issues for RES users in r/IAMA. Don't know whether this is a problem for RES users in the porns though - I don't use RES.)
There is growing contention between CSS authors and addon developers, I sense the need for a Working Group and an RFC.
[deleted]
Yes, that could work. I do think they need to be noticeably different from each other, I was just searching in r/mapporn and almost clicked on the submit button instead. I'll wager you have done/will soon do the same... ;)
Positioning - I don't know much about subreddit CSS, so I shall abstain from further comment, except to say that relative positioning would likely enhance the porns for anyone using various kinds of addon.
I was sort-of serious about the RFC. Is/was r/apple right to disable RES' disable CSS button? Is honestbleeps right in thinking it's should be the user's choice? What is a developer to do if wanting to maximize compatibility with subreddit CSS? What can CSS authors do to display their subs correctly with addons enabled? These questions and more are yet to be answered...
Is/was [1] r/apple right to disable RES' disable CSS button?
No: http://www.reddit.com/help/moderation#ArethereanyrestrictionsonwhatIcandowithmyredditsCSS
You are pretty much free to make any style modifications you would like, within reason. Some things you can't do:
Disable or tamper with site functionality (e.g., buttons)
[deleted]
since you're claiming you never said you don't like RES, I suppose now that I've run across this I may as well reply to it...
Pi31415926 asked "Is/was r/apple right to disable RES' disable CSS button?" - you said:
Yes.
Well, I disagree. Reddit already provides a means to disable your stylesheet. RES just makes it easier.
Pi asked: "Is honestbleeps right in thinking it's should be the user's choice?"
To which you responded as follows:
No.
Moderators can do whatever they want. They have complete control over their subreddits (see r/Pyongyang and r/CCCP for some great examples). Some of us are good, some of us are bad, but that's why anyone can create a community and anyone can unsubscribe.
I personally don't like RES or anyone who complains that we are ruining their third party add-on experience. You wouldn't call a game developer to ask for help trying to get a third party mod to work so why would you do that here?
Though, it would be nice (and beneficial for everyone) if the two groups could get together and work something out but that, unfortunately, will probably never happen (at least not anytime soon).
That being said, I will try and fix the things you want fixing since it not only interrupts RES but also Reddit Companion and Serendipity, one of which is awesome and the other is made by Reddit.
So, to go back to the CSS. Would it be better if the search button was on top and the submit button was on the bottom and they were separated by an image? That way it would be somewhat intuitive since that's the order (although there is a lot more in between) by default?
Well now.. I'd like to respond to a few of your points...
Moderators can do whatever they want. They have complete control over their subreddits
This is false.
Reddit allows us to disable stylesheets for subreddits.
Reddit has specific rules about things you're not allowed to do with CSS, including but not limited to things like swapping out usernames as a means of trickery, etc. You cannot do whatever you want...
I personally don't like RES or anyone who complains that we are ruining their third party add-on experience.
Well, certainly I never in my wildest dreams thought that RES would get big enough that this would become a problem for you. I do apologize that it has become a problem - that's not something I ever wanted.
However... you then go here:
Though, it would be nice (and beneficial for everyone) if the two groups could get together and work something out but that, unfortunately, will probably never happen (at least not anytime soon).
Why? Why wouldn't this happen? I've been extremely responsive to anyone asking for help with RES, including making changes to RES to make it play more nicely with subreddit designs.
In addition, I've added body classes to make it easier for moderators to style with RES in mind (i.e. night mode), etc.
I don't mind that you dislike RES, and I can totally empathize with the fact that it's bothersome that you're getting people complaining to you that your styles don't play nice with RES. Obviously that's a bummer because you already do enough work as it is on the stylesheets and being asked to do more work is frustrating. I do empathize with that.
At the end of the day, it's your prerogative to choose whether or not you want to do that work.
Know these two things, however:
I am more than willing to work with you to make that task easier. I have the utmost respect for the hard work that goes into the more advanced / interesting uses of CSS on Reddit.
One place where we will never see eye to eye, apparently, is on what is a users' choice. The thing is, Reddit itself provides the option to turn off subreddit stylesheets. The stylesheets were not put here as a means for you to "control" the experience. That you and others have started to use it for that is an interesting and unexpected development that has ended up having both positive and negative effects depending on uses, etc --- but it was not Reddit's intended use so far as I can surmise, especially because I have a reddit-provided setting to turn it off...
We can agree to disagree on point #2. On point #1, the door's open. If you'd like me to make any changes to RES to make it play better with your subreddit, I'm open to working together on that.
Yes, I do think that if the search was on top and the submit below, that would be more intuitive. I agree with your goal, which is to make the submit button easier to find, but that gain is lost if the button gets confused with another element. So there is a balance to be found, what you suggested sounds good - you could use some color to further differentiate them (as done in r/pornoverlords). Separating with an image also good, it's only my 2c but I do think they need to be clearly different from each other.
Thanks also for looking at the absolute positioning issue (I do get a similar effect to that shown in the RES r/IAMA screencap I linked). It's not a big deal though, I can just click unhide to fix. I also haven't looked into other ways I might fix it (such rewriting the relevant CSS with a script).
Long-term, I do worry about compatibility, not just between custom CSS and various addons, but also between addons. The alternative to an agreed protocol is a disaster area. This situation has many precedents (the pre-ASCII world, the pre-TCP/IP world, the pre-HTML world, etc).
I absolutely agree that moderators are in charge of their subreddits. However, I am in charge of my computer. This is not a political view, it's a statement of fact. It's a big issue - companies such as Sony and Apple spend billions on anti-jailbreak technology. What we have here is a microcosm of that same debate - I don't find it surprising that it arose in r/apple. Those companies try and get their way by using ToS clauses, the DMCA, patents, and proprietary, incompatible and obfuscated technologies. Does Reddit give subreddits and moderators the same abilities? An agreed protocol is a way to avoid the cat-and-mouse game that will occur as the answer to this question is found.
This is not a politics thread, so I won't continue. :) As it's a live issue, I expect it will come up again.
You wouldn't call a game developer to ask for help trying to get a third party mod to work so why would you do that here?
My full-time job is to support third party mods for the AAA game I work on. So . . . yeah, lots of people do exactly that.
The job of a game developer is to make a fun game, not shoehorn players into their vision of what the game should be. Shoehorning players into that vision may be what they think makes a fun game, but in the end, the game's the priority.
Your job as a moderator is to make a good subreddit. If RES makes that harder, hey, sympathies, that sucks, but it doesn't stop being part of your job.
hate it - doesn't work properly on my touchpad.
[deleted]
It works fine on my iPad - what are you using?
Don't like it all, I much preferred each network link on the side a lot better (and was a lot more convenient) than the auto-pulldown menus on the top.
[deleted]
The current sidebar is by no means bad either. However, how about including each subreddit link separately on the top. With the new auto-pulldown menus, I feel that lesser-known/less-visited SFWPorn subreddits will suffer in the longrun.
Just my 2 cents..
[deleted]
Yes, exactly.
So essentially, what I'm saying is have the links(to each different subreddit) on the right side of the banner while the left side of the banner can be a picture relating to the SFWPorn subreddit.
I just think that having a link to each SFWPorn subreddit without a pulldown will increase exposure to all of the SFWPorn subreddits.
Does that sound any better?
This style is incredibly ugly.
It is a huge image banner that is needless and takes up valuable screen space.
I turned it off, so no biggie, but the banner is supposed to be useful, and I'm not using it.
[deleted]
Nope. I'm talking about the current one. I find it hard to believe that it could have been worse previously
[deleted]
He is saying that the 300px height of the banner takes up to much space. I disagree with because it is not a fixed banner.
The layout is fine, I suppose it looks quite nice actually. However, I frankly don't care about the layout.
What I don't like is your removal of all videos. I don't see why you have to be such Nazi's about it. I only subscribe to Adrenalineporn which includes, and should rightly include, videos. It seems silly that you only allow images.
Thankfully, r/adrenaline has been created so I can see videos AND images without having to satisfy your desire for resolutions, etc.
Thankfully, r/adrenaline has been created
I love it. It's been added to the sidebar of /r/AdrenalinePorn
[deleted]
Apologies, I genuinely am sorry.
I saw the post on the sidebar which said "Like the new style? Hate the new style? Let us know!" I assumed that removal of videos, being a new addition, was part of the "new style". Clearly I am mistaken. I will repost elsewhere.
Although, this is exactly my point. You guys need to chill out a bit and let people enjoy your subreddits.
[deleted]
Thank you.
Pretty damn awful if I'm honest. I don't use the rest of the SFWPorn network but /r/adrenalineporn has been ruined (Like no videos, anal regulations, and a pixilated top image that is covered in the tabs). General boo, sorry.
[deleted]
Using Reddit Enhancement Suite (and Opera), my browser stops responding/crashes whenever I go to any SFWPorn network subreddit. I used RES to disable Subreddit style over at /r/QuotesPorn and now I can see the site fine, and did the same thing and now this subreddit works. It's a bitch to disable, though, because the majority of the time the browser crashes before I can deselect "use subreddit style".
[deleted]
may I ask what indicates to you that this is a problem with RES?
Frankly, I don't think it's a problem with your CSS or RES, but rather the user's browser.
I think it's a little weird of you to blame this on RES, which I'm using right now and having no problems with.
[deleted]
It's not related to RES. I see you don't like it, and that's perfectly fine, but it's his browser.
I should have guessed, just thought I should tell you.
Is there anyway you guys can make a link to the Reddit homepage near the banner, that'd be so helpful! But great new theme guys, good job!
[deleted]
Ahh, yeah I got it, thanks. And you probably should considering it's not very visible, a small little sfw porn alien would be great!
Hey, I've been teaching myself CSS lately in order to work on some subs I mod. I am very impressed with the menu and the drop down lists on hover, great job. Peering into the inner workings of your stylesheet is very enlightening.
I love what you guys have done with this group of subreddits, probably some of the greatest designs and best uses of CSS available on reddit.
We've recently plagiarised copied your previous design (sidebar image links) for our book surveys in r/SF_Book_Club. We've also decided to follow your posting guidelines with respect to reposts in r/SpecArt. As they say: "Imitation is the highest form of flattery"
It seems the critics as usual are the most outspoken but keep up the good work.
[deleted]
love it!
[deleted]
Love it!
Love it!
I like it
Thank you SO much!! It's a lot better than having them all clumped up in the sidebar, and now I can free up space in my top bar.