Bug report: reddit now has amp links

🔨 Bug Report

##Bug report:

In this comment we had the link:

https://amp-reddit-com.cdn.ampproject.org/wp/s/amp.reddit.com/r/CombatFootage/comments/o765q4/russian_coast_guard_video_of_hms_defender/?usqp=mq331AQKKAFQArABIIACAw%3D%3D

AmputatorBot was summoned and it ended up with this link:

https://amp-reddit-com.cdn.ampproject.org/wp/s/reddit.com/r/CombatFootage/comments/o765q4/russian_coast_guard_video_of_hms_defender/?usqp=mq331AQKKAFQArABIIACAw%3D%3D

And this message:

Still AMP, but no longer cached - unable to process further

The canonical URL should be:

https://www.reddit.com/r/CombatFootage/comments/o765q4/russian_coast_guard_video_of_hms_defender/

##Suggested action:

Since this is happening on reddit itself, reddit amp links are probably going to be common. If a canonical URL cannot be extracted, I suggest hardcoding a regexp translation to produce canonical URLs.

Thank you.

Posted Jul 21, 2021, 3:23 PM UTC

179

Sort by:

aeon314159•5 yr. ago

I think this is a good idea, and I have experienced this problem once before. I love summoning AmputatorBot.

kc2sykOP•5 yr. ago

Thanks, I hope u/Killed_Mufasa agrees.

lemurrhino•5 yr. ago

Hey, my friend made a PR fixing this issue on the github repo. It's up to the owner to accept it. We found this bug as well when migrating the code to work with our discord bot.

kc2sykOP•5 yr. ago

https://github.com/KilledMufasa/AmputatorBot/pull/13

That's great! Thank you

Killed_Mufasa•4 yr. ago

Hi u/lemurrhino, u/kc2syk and u/aeon314159! Thx a lot for submitting and contributing to this feature request. Sorry for not getting back to you sooner. As u/lemurrhino said, his friend was incredibly kind to submit a pull-request. I've since merged this into the codebase, and it works! As AmputatorBot will hopefully demonstrate now for us:

PS, I announced an API for AmputatorBot just now: https://www.reddit.com/r/AmputatorBot/comments/qpqipw/amputatorbot_v4_a_brandnew_api_databasecaching/ - I hope you dig it!

kc2sykOP•4 yr. ago

Yay! Thank you!

Killed_Mufasa•4 yr. ago

No worries, thank you for bringing this to our attention :)

lemurrhino•4 yr. ago

Funny timing, we wrote our own a few weeks ago haha. Your's looks better though.

AmputatorBot•4 yr. ago

It looks like you shared some AMP links. These should load faster, but AMP is controversial because of concerns over privacy and the Open Web. Fully cached AMP pages (like some of the ones you shared), are especially problematic.

Maybe check out the canonical pages instead:

^(I'm a bot | )^(Why & About)^( | )[^(Summon: u/AmputatorBot)](https://www.reddit.com/r/AmputatorBot/comments/cchly3/you_can_now_summon_amputatorbot/)